Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476AbYCFMZi (ORCPT ); Thu, 6 Mar 2008 07:25:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765921AbYCFMZV (ORCPT ); Thu, 6 Mar 2008 07:25:21 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:34422 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753683AbYCFMZT (ORCPT ); Thu, 6 Mar 2008 07:25:19 -0500 Date: Thu, 6 Mar 2008 07:25:18 -0500 From: Christoph Hellwig To: Jonas Bonn Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com Subject: Re: struct pci_device_id declaration cleanups Message-ID: <20080306122518.GB28561@infradead.org> References: <1204800947-21569-1-git-send-email-jonas@southpole.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1204800947-21569-1-git-send-email-jonas@southpole.se> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 618 Lines: 14 On Thu, Mar 06, 2008 at 11:55:38AM +0100, Jonas Bonn wrote: > > This set of patches applies the macro DECLARE_PCI_DEVICE_TABLE to the > declarations of struct pci_device_id in several network drivers. The drivers > build cleanly with these patches (without any new warnings) on both x86 and > PowerPC. Why would we want this macro? It looks slightly ugly at least.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/