Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932693AbYCFMgA (ORCPT ); Thu, 6 Mar 2008 07:36:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756309AbYCFMfw (ORCPT ); Thu, 6 Mar 2008 07:35:52 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:57520 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754805AbYCFMfv (ORCPT ); Thu, 6 Mar 2008 07:35:51 -0500 Date: Thu, 6 Mar 2008 07:35:51 -0500 From: Christoph Hellwig To: Laurent Vivier Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] Modify loop device to be able to manage partitions of the disk image Message-ID: <20080306123551.GA10609@infradead.org> References: <1204796612842-git-send-email-Laurent.Vivier@bull.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1204796612842-git-send-email-Laurent.Vivier@bull.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1129 Lines: 23 On Thu, Mar 06, 2008 at 10:43:32AM +0100, Laurent Vivier wrote: > This patch allows to use loop device with partitionned disk image. > > Original behavior of loop is not modified. > > A new parameter is introduced to define how many partition we want to be > able to manage per loop device. This parameter is "max_part". I've done something else before as have done others, but at that time we didn't want it in because it breaks the device number encoding. Nowdays where a lot of systems use udev it probably makes sense to put it in. The default is to not show any partitions which is safe. Did you test if udev is smart enough to find out loop has partitions when loaded with the paramater? If yes this can go in with a little documentation added, if not please also work with the udev folks to find a way to automatically detect that loop can sometimes support partitions. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/