Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934243AbYCFNQm (ORCPT ); Thu, 6 Mar 2008 08:16:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752691AbYCFNQ3 (ORCPT ); Thu, 6 Mar 2008 08:16:29 -0500 Received: from smtp-out2.tiscali.nl ([195.241.79.177]:49298 "EHLO smtp-out2.tiscali.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934127AbYCFNQ2 (ORCPT ); Thu, 6 Mar 2008 08:16:28 -0500 Message-ID: <47CFEE9D.1020300@tiscali.nl> Date: Thu, 06 Mar 2008 14:16:13 +0100 From: Roel Kluin <12o3l@tiscali.nl> User-Agent: Thunderbird 2.0.0.9 (X11/20071031) MIME-Version: 1.0 To: paulus@samba.org, arnd@arndb.de CC: linuxppc-dev@ozlabs.org, lkml Subject: [PATCH] PPC: in celleb_show_cpuinfo() convert strncpy(x, y, sizeof(x)) to strlcpy Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 25 This patch was not yet tested. Please confirm it's right. --- strncpy does not append '\0' if the length of the source string equals the size parameter, strlcpy does. Signed-off-by: Roel Kluin <12o3l@tiscali.nl> --- diff --git a/arch/powerpc/platforms/celleb/setup.c b/arch/powerpc/platforms/celleb/setup.c index f27ae1e..d70fc53 100644 --- a/arch/powerpc/platforms/celleb/setup.c +++ b/arch/powerpc/platforms/celleb/setup.c @@ -81,7 +81,7 @@ static void celleb_show_cpuinfo(struct seq_file *m) static int __init celleb_machine_type_hack(char *ptr) { - strncpy(celleb_machine_type, ptr, sizeof(celleb_machine_type)); + strlcpy(celleb_machine_type, ptr, sizeof(celleb_machine_type)); celleb_machine_type[sizeof(celleb_machine_type)-1] = 0; return 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/