Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935143AbYCFQ2y (ORCPT ); Thu, 6 Mar 2008 11:28:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934928AbYCFQ1g (ORCPT ); Thu, 6 Mar 2008 11:27:36 -0500 Received: from e36.co.us.ibm.com ([32.97.110.154]:59259 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934919AbYCFQ1e (ORCPT ); Thu, 6 Mar 2008 11:27:34 -0500 Date: Thu, 6 Mar 2008 08:27:24 -0800 From: "Paul E. McKenney" To: Dave Young Cc: Jike Song , Linux Kernel Subject: Re: 2.6.25-rc4 rcupreempt.h WARNINGs while suspend/resume Message-ID: <20080306162724.GA9309@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20080305165531.GB8728@linux.vnet.ibm.com> <20080306022854.GK8728@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 50 On Thu, Mar 06, 2008 at 07:08:55PM +0800, Dave Young wrote: > On Thu, Mar 6, 2008 at 11:20 AM, Dave Young wrote: > > On Thu, Mar 6, 2008 at 10:28 AM, Paul E. McKenney > > > > wrote: > > > > > > On Thu, Mar 06, 2008 at 10:11:26AM +0800, Jike Song wrote: > > > > On Thu, Mar 6, 2008 at 12:55 AM, Paul E. McKenney > > > > wrote: > > > > > Could you please try applying Karsten Wiese's patch to see if it > > > > > fixes the WARNINGs? See http://lkml.org/lkml/2008/2/26/386 for > > > > > the patch. > > > > > > > > > > Thanx, Paul > > > > > > > > Yes, the WARNING disappears with Karsten's patch applied. > > > > Thanks. > > > > Confirmed > > > > > > > > > > > > Good to hear!!! I believe that Karsten's patch is on its way in, > > > so hopefully that will clear things up. > > Hi, paul > > My syslog became a 2G size big file yestoday due to the warnings. > How about change the WARN_ON to WARN_ON_ONCE? Hello, Dave, I might be convinced to make this change for 2.6.26, but the condition that the WARN_ON() is complaining about is quite serious, so I don't want to take a chance on it getting lost in the noise in the 2.6.25 series. Seem reasonable? Better yet, is there some sort of time-limited WARN_ON that kicks out a message at most once per second or some such? Enough to definitely be noticed, but not enough to bring the machine to its knees? Thanx, Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/