Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764121AbYCGBn2 (ORCPT ); Thu, 6 Mar 2008 20:43:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753265AbYCGBnR (ORCPT ); Thu, 6 Mar 2008 20:43:17 -0500 Received: from namei.org ([69.55.235.186]:52742 "EHLO us.intercode.com.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753124AbYCGBnQ (ORCPT ); Thu, 6 Mar 2008 20:43:16 -0500 Date: Fri, 7 Mar 2008 12:42:03 +1100 (EST) From: James Morris X-X-Sender: jmorris@us.intercode.com.au To: "Ahmed S. Darwish" cc: Chris Wright , Stephen Smalley , Eric Paris , Casey Schaufler , Paul Moore , Alexey Dobriyan , Andrew Morton , Linus , LKML , LSM-ML Subject: Re: [PATCH -v8b -rc3] Security: Introduce security= boot parameter In-Reply-To: <20080306160910.GA10319@ubuntu> Message-ID: References: <20080306121913.GA8506@ubuntu> <1865922a0803060632kb63405fj3d255472fb2e555f@mail.gmail.com> <20080306160910.GA10319@ubuntu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1720 Lines: 51 On Thu, 6 Mar 2008, Ahmed S. Darwish wrote: > + * Each LSM must pass this method before registering its own operations > + * to avoid security registration races. This method may also be used > + * to check if your LSM is currently loaded. The 2nd sentence is no longer correct in general, as the function can only be called during init. See a fixup patch below. Otherwise, looks good! Acked-by: James Morris I've applied the patch and a comment fixup to git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6.git#next commit d6bb3bacedb68aa41ea7598e0cf1bef33cebbcc9 Author: James Morris Date: Fri Mar 7 12:23:49 2008 +1100 security: fix up documentation for security_module_enable security_module_enable() can only be called during kernel init. Signed-off-by: James Morris diff --git a/security/security.c b/security/security.c index 4377b00..8aa2f54 100644 --- a/security/security.c +++ b/security/security.c @@ -83,7 +83,7 @@ __setup("security=", choose_lsm); * * Each LSM must pass this method before registering its own operations * to avoid security registration races. This method may also be used - * to check if your LSM is currently loaded. + * to check if your LSM is currently loaded during kernel initialization. * * Return true if: * -The passed LSM is the one chosen by user at boot time, -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/