DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=bGKgTsyvNa4SQFv8wAEz0ayb7RqNAYRLnZ8n2OU/jr6125Urm0OBWdBMfVCVjEsb3u5cttrUhNzQkSbjM5JWCIuwXfGt7+oX0bJ3XLIPFTYGhEc2R+jEgSUyOUsH17ifrV3wWeY+iBnESnWL1jW/mj1wnDGQOY2QEADgD0LQcbw=
Message-ID: <a8e1da0803061907k72785f10t2dcb98ca9829e2d8@mail.gmail.com>
Date: Fri, 7 Mar 2008 11:07:48 +0800
From: "Dave Young" <hidave.darkstar@gmail.com>
To: paulmck@linux.vnet.ibm.com
Subject: Re: 2.6.25-rc4 rcupreempt.h WARNINGs while suspend/resume
Cc: "Jike Song" <albcamus@gmail.com>,
       "Linux Kernel" <linux-kernel@vger.kernel.org>
In-Reply-To: <20080306162724.GA9309@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <a8e1da0803042324ndd3873ay61cee6112d9dda9a@mail.gmail.com>
	 <df9815e70803042335j4ea66028y96d6be21f0970aa1@mail.gmail.com>
	 <20080305165531.GB8728@linux.vnet.ibm.com>
	 <df9815e70803051811o4c4a42e0td56cfd32b80c66b2@mail.gmail.com>
	 <20080306022854.GK8728@linux.vnet.ibm.com>
	 <a8e1da0803051920t586c7fbapadda70ae895f8893@mail.gmail.com>
	 <a8e1da0803060308o690c1545l1eaffc0c40f2bc7e@mail.gmail.com>
	 <20080306162724.GA9309@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2160
Lines: 60

On Fri, Mar 7, 2008 at 12:27 AM, Paul E. McKenney
<paulmck@linux.vnet.ibm.com> wrote:
>
> On Thu, Mar 06, 2008 at 07:08:55PM +0800, Dave Young wrote:
>  > On Thu, Mar 6, 2008 at 11:20 AM, Dave Young <hidave.darkstar@gmail.com> wrote:
>  > > On Thu, Mar 6, 2008 at 10:28 AM, Paul E. McKenney
>  > >
>  > > <paulmck@linux.vnet.ibm.com> wrote:
>  > >  >
>  > >  > On Thu, Mar 06, 2008 at 10:11:26AM +0800, Jike Song wrote:
>  > >  >  > On Thu, Mar 6, 2008 at 12:55 AM, Paul E. McKenney
>  > >  >  > <paulmck@linux.vnet.ibm.com> wrote:
>  > >  >  > >  Could you please try applying Karsten Wiese's patch to see if it
>  > >  >  > >  fixes the WARNINGs?  See http://lkml.org/lkml/2008/2/26/386 for
>  > >  >  > >  the patch.
>  > >  >  > >
>  > >  >  > >                                                 Thanx, Paul
>  > >  >  >
>  > >  >  > Yes, the WARNING disappears with Karsten's patch applied.
>  > >  >  > Thanks.
>  > >
>  > >  Confirmed
>  > >
>  > >
>  > >
>  > >  >
>  > >  >  Good to hear!!!  I believe that Karsten's patch is on its way in,
>  > >  >  so hopefully that will clear things up.
>  >
>  > Hi, paul
>  >
>  > My syslog became a 2G size big file yestoday due to the warnings.
>  > How about change the WARN_ON to WARN_ON_ONCE?
>
>  Hello, Dave,
>
>  I might be convinced to make this change for 2.6.26, but the condition
>  that the WARN_ON() is complaining about is quite serious, so I don't
>  want to take a chance on it getting lost in the noise in the 2.6.25
>  series.
>
>  Seem reasonable?

IMHO, WARN_ON_ONCE is enough for my eyes :)

>
>  Better yet, is there some sort of time-limited WARN_ON that kicks out
>  a message at most once per second or some such?  Enough to definitely
>  be noticed, but not enough to bring the machine to its knees?

Seems there's no such functions/macros, but is is really needed?

>
>                                                         Thanx, Paul
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/