Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760011AbYCGKur (ORCPT ); Fri, 7 Mar 2008 05:50:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755038AbYCGKuk (ORCPT ); Fri, 7 Mar 2008 05:50:40 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:32798 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755183AbYCGKuj (ORCPT ); Fri, 7 Mar 2008 05:50:39 -0500 Date: Fri, 7 Mar 2008 05:50:25 -0500 From: Christoph Hellwig To: Oleg Nesterov Cc: Andrew Morton , "Eric W. Biederman" , Ingo Molnar , Roland McGrath , linux-kernel@vger.kernel.org Subject: Re: [PATCH] signals: do_tkill: don't use tasklist_lock Message-ID: <20080307105025.GB20000@infradead.org> References: <20080307095813.GA8894@tv-sign.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080307095813.GA8894@tv-sign.ru> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 576 Lines: 12 On Fri, Mar 07, 2008 at 12:58:13PM +0300, Oleg Nesterov wrote: > Note that we don't return an error if lock_task_sighand() fails, we pretend the > task dies after receiving the signal. Otherwise, we should fight with the nasty > races with mt-exec without having any advantage. This should be mentioned in a comment in the code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/