Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761289AbYCGLJc (ORCPT ); Fri, 7 Mar 2008 06:09:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756109AbYCGLJZ (ORCPT ); Fri, 7 Mar 2008 06:09:25 -0500 Received: from fg-out-1718.google.com ([72.14.220.154]:59919 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756715AbYCGLJY (ORCPT ); Fri, 7 Mar 2008 06:09:24 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=syMtTswyu4N8L/8zHZPX2CQlaVa6rjcuioUW08wkhicSCP3/mRpaRo+8dv9OjCSNeNo/BFeFVTgNJCEac6HJUfI2hXwLzGq9A8BWZVXBK9HOajq9oMs5JDP5T8zGoCeuYknBUaPfcDQMoj+yblVQ/r4iuzYQ6NH2yHsRLqfalTY= Message-ID: Date: Fri, 7 Mar 2008 19:09:22 +0800 From: "ye janboe" To: "Russell King - ARM Linux" Subject: Re: [PATCH] fix signal return code when enable CONFIG_OABI_COMPAT Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org In-Reply-To: <20080306153337.GM3283@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080306153337.GM3283@flint.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1775 Lines: 51 Russell I resubmit my patch, please review it. Thanks commit 31644e57359644d3f376f293f1a45b7c181175b6 Author: janboe Date: Thu Mar 6 23:00:23 2008 +0800 fix signal return code when enable CONFIG_OABI_COMPAT Signed-off-by: Janboe Ye diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c index 54cdf1a..ef2f86a 100644 --- a/arch/arm/kernel/signal.c +++ b/arch/arm/kernel/signal.c @@ -26,8 +26,8 @@ /* * For ARM syscalls, we encode the syscall number into the instruction. */ -#define SWI_SYS_SIGRETURN (0xef000000|(__NR_sigreturn)) -#define SWI_SYS_RT_SIGRETURN (0xef000000|(__NR_rt_sigreturn)) +#define SWI_SYS_SIGRETURN (0xef000000|(__NR_sigreturn)|(__NR_OABI_SYSCALL_BASE)) +#define SWI_SYS_RT_SIGRETURN (0xef000000|(__NR_rt_sigreturn)|(__NR_OABI_SYSCALL_BASE)) /* * With EABI, the syscall number has to be loaded into r7. 2008/3/6, Russell King - ARM Linux : > On Thu, Mar 06, 2008 at 11:14:50PM +0800, ye janboe wrote: > > commit b4e8bde513a9a477c30c8769073ced7b59676d48 > > Author: janboe > > Date: Thu Mar 6 23:00:23 2008 +0800 > > > > fix signal return code when enable CONFIG_OABI_COMPAT. > > because this will make kernel report this syscall obsolete. > > Signed-off-by: Janboe Ye > > > This is all horribly broken for OABI compat anyway (because __NR_* don't > contain the right prefix). So this patch doesn't actually fix the real > problem. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/