Date: Fri, 7 Mar 2008 09:51:52 -0800
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] [6/13] Core maskable allocator
Message-Id: <20080307095152.93a8d1ca.randy.dunlap@oracle.com>
In-Reply-To: <20080307174316.GJ7365@one.firstfloor.org>
References: <200803071007.493903088@firstfloor.org>
	<20080307090716.9D3E91B419C@basil.firstfloor.org>
	<20080307090517.b6b27987.randy.dunlap@oracle.com>
	<20080307173146.GI7365@one.firstfloor.org>
	<47D17C4E.9000302@oracle.com>
	<20080307174316.GJ7365@one.firstfloor.org>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1274
Lines: 39

On Fri, 7 Mar 2008 18:43:16 +0100 Andi Kleen wrote:

> On Fri, Mar 07, 2008 at 09:33:02AM -0800, Randy Dunlap wrote:
> > Andi Kleen wrote:
> > >>>+	maskzone=size[MG] Set size of maskable DMA zone to size.
> > >>>+		 force	Always allocate from the mask zone (for testing)
> > >>                 ^^^^^^^^^^^^^ ??
> > >
> > >What is your question?
> > 
> > That line seems odd.  Is it correct?
> > Why 2 spaces between force and Always?  Why is Always capitalized?
> > Could one of those words be dropped?  They seem a bit redundant.
> 
> The option is either maskzone=size[MG] or maskzone=force
> Each followed with a sentence describing them.

Oh.  I see.

> I tried to make this clear by lining them up, but apparently failed.
> You have a preferred way to formatting such multiple choice options?

I don't know that we have a certain/fixed way for that.

How about:

	maskzone=
		Format: {size[MG] | force}
		size -- Set size of maskable DMA zone to size
		force -- Always allocate from the mask zone (for testing)


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/