Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758237AbYCGSVt (ORCPT ); Fri, 7 Mar 2008 13:21:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758495AbYCGSVg (ORCPT ); Fri, 7 Mar 2008 13:21:36 -0500 Received: from 136-022.dsl.labridge.com ([206.117.136.22]:2104 "EHLO mail.perches.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754998AbYCGSVf (ORCPT ); Fri, 7 Mar 2008 13:21:35 -0500 Subject: Re: [E1000-devel] [PATCH] drivers/net: convert & to && From: Joe Perches To: "Kok, Auke" Cc: Julia Lawall , e1000-devel@lists.sourceforge.net, xfs-masters , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <47D032FA.9000909@intel.com> References: <1204826347.5541.20.camel@localhost> <47D032FA.9000909@intel.com> Content-Type: text/plain Date: Fri, 07 Mar 2008 10:20:33 -0800 Message-Id: <1204914033.5541.74.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3-1.1mdv2008.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1676 Lines: 37 On Thu, 2008-03-06 at 10:07 -0800, Kok, Auke wrote: > (which, BTW also could use the uint32_t -> u32 (etc) changes... while you're at it) I think this does what you want: for size in "8" "16" "32" "64" ; do \ sed -r -i -e 's/\bu_{0,1}int'$size'_t\b/u'$size'/g' \ $(grep -rPlw --include=*.[ch] 'u_{0,1}int'$size'_t' drivers/net/e1000 drivers/net/ixgb); done But why? boolean_t is used by 3 subsystems with local typedefs. These others are much more frequently used by kernel source. $ grep -rPlw --include=*.[ch] "u{0,1}_{0,1}int(8|16|32|64)_t" * | wc -l 876 include/linux/types.h has typedefs for these but not boolean_t include/linux/types.h:typedef __u8 u_int8_t; include/linux/types.h:typedef __s8 int8_t; include/linux/types.h:typedef __u16 u_int16_t; include/linux/types.h:typedef __s16 int16_t; include/linux/types.h:typedef __u32 u_int32_t; include/linux/types.h:typedef __s32 int32_t; include/linux/types.h:typedef __u8 uint8_t; include/linux/types.h:typedef __u16 uint16_t; include/linux/types.h:typedef __u32 uint32_t; include/linux/types.h:typedef __u64 uint64_t; include/linux/types.h:typedef __u64 u_int64_t; include/linux/types.h:typedef __s64 int64_t; cheers, Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/