Date: Fri, 7 Mar 2008 20:09:09 +0100
From: Sam Ravnborg <sam@ravnborg.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] [8/13] Enable the mask allocator for x86
Message-ID: <20080307190909.GA15512@uranus.ravnborg.org>
References: <200803071007.493903088@firstfloor.org> <20080307090718.A609E1B419C@basil.firstfloor.org> <20080307183255.GB14779@uranus.ravnborg.org> <20080307190313.GN7365@one.firstfloor.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080307190313.GN7365@one.firstfloor.org>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1111
Lines: 24

On Fri, Mar 07, 2008 at 08:03:13PM +0100, Andi Kleen wrote:
> On Fri, Mar 07, 2008 at 07:32:55PM +0100, Sam Ravnborg wrote:
> > On Fri, Mar 07, 2008 at 10:07:18AM +0100, Andi Kleen wrote:
> > > 
> > > - Disable old ZONE_DMA
> > > No fixed size ZONE_DMA now anymore. All existing users of __GFP_DMA rely 
> > > on the compat call to the maskable allocator in alloc/free_pages
> > > - Call maskable allocator initialization functions at boot
> > > - Add TRAD_DMA_MASK for the compat functions 
> > 
> > I see TRAD_DMA_MASK used by patch 6 and patch 7, but only here
> > in this later patch it is defined.
> > Looks like we have build breakage - but I have not checked it.
> 
> It is only used when the architecture defines CONFIG_MASK_ALLOC and
> that is not done by any until the later patches.
Understood - I just took a quick look and wanted to let you know.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/