Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764164AbYCGUES (ORCPT ); Fri, 7 Mar 2008 15:04:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757122AbYCGUEG (ORCPT ); Fri, 7 Mar 2008 15:04:06 -0500 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:60239 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756853AbYCGUEF (ORCPT ); Fri, 7 Mar 2008 15:04:05 -0500 Date: Fri, 7 Mar 2008 12:03:42 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Andrea Arcangeli cc: Jack Steiner , Nick Piggin , akpm@linux-foundation.org, Robin Holt , Avi Kivity , kvm-devel@lists.sourceforge.net, Peter Zijlstra , general@lists.openfabrics.org, Steve Wise , Roland Dreier , Kanoj Sarcar , linux-kernel@vger.kernel.org, linux-mm@kvack.org, daniel.blueman@quadrics.com Subject: Re: [PATCH] 4/4 i_mmap_lock spinlock2rwsem (#v9 was 1/4) In-Reply-To: <20080307155244.GF24114@v2.random> Message-ID: References: <20080303213707.GA8091@v2.random> <20080303220502.GA5301@v2.random> <47CC9B57.5050402@qumranet.com> <20080304133020.GC5301@v2.random> <20080304222030.GB8951@v2.random> <20080307151722.GD24114@v2.random> <20080307152328.GE24114@v2.random> <20080307155244.GF24114@v2.random> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 695 Lines: 15 On Fri, 7 Mar 2008, Andrea Arcangeli wrote: > I didn't look into this but it shows how it would be risky to make > this change in .25. It's a bit strange that the bugcheck triggers Yes this was never intended for .25. I think we need to split this into a copule of patches. One needs to get rid of the spinlock dropping, then one that deals with the read concurrency issues and finally one that converts the spinlock. Thanks for looking at it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/