Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932500AbYCGViT (ORCPT ); Fri, 7 Mar 2008 16:38:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761273AbYCGVh7 (ORCPT ); Fri, 7 Mar 2008 16:37:59 -0500 Received: from gateway-1237.mvista.com ([63.81.120.158]:42465 "EHLO gateway-1237.mvista.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761216AbYCGVh6 (ORCPT ); Fri, 7 Mar 2008 16:37:58 -0500 Subject: Re: [PATCH] drivers/pcmcia/soc_common.c: convert soc_pcmcia_sockets_lock in a mutex From: Daniel Walker To: Matthias Kaehlcke Cc: linux-pcmcia@lists.infradead.org, nico@cam.org, rmk@arm.linux.org.uk, linux-kernel@vger.kernel.org, akpm@linux-foundation.org In-Reply-To: <20080307183742.GF2783@traven> References: <20080307183742.GF2783@traven> Content-Type: text/plain Date: Fri, 07 Mar 2008 13:37:55 -0800 Message-Id: <1204925875.10627.9.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-1.fc8) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 16 On Fri, 2008-03-07 at 19:37 +0100, Matthias Kaehlcke wrote: > extern struct list_head soc_pcmcia_sockets; > -extern struct semaphore soc_pcmcia_sockets_lock; > +extern struct mutex soc_pcmcia_sockets_lock; If it's extern'ed I wonder where else it's getting used? If it's not used anyplace else, may as werll remove the extern and make it static .. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/