Date: Sat, 8 Mar 2008 09:41:18 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Gregory Haskins <ghaskins@novell.com>
Cc: suresh.b.siddha@intel.com, rjw@sisk.pl, akpm@linux-foundation.org,
       dmitry.adamushko@gmail.com, ego@in.ibm.com, oleg@sign.ru,
       yi.y.yang@intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] adjust root-domain->online span in response to hotplug
	event
Message-ID: <20080308084118.GA24552@elte.hu>
References: <20080308015045.GB15909@linux-os.sc.intel.com> <20080308050627.4831.87630.stgit@novell1.haskins.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080308050627.4831.87630.stgit@novell1.haskins.net>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1069
Lines: 24


* Gregory Haskins <ghaskins@novell.com> wrote:

>    Unfortunately, this patch will introduce its own set of bugs. 
> However, your analysis was spot-on.  I think I see the problem now.  
> It was introduced when I put a hack in to "fix" s2ram problems in -mm 
> as a result of the new root-domain logic.  I think the following patch 
> will fix both issues:
> 
> (I verified that I could take a cpu offline/online, but I don't have 
> an s2ram compatible machine handy.  Andrew, I believe you could 
> reproduce the s2ram problem a few months ago when that issue popped 
> up.  So if you could, please verify that s2ram also works with this 
> patch applied, in addition to the hotplug problem.

thanks Gregory, i've queued up your fix. If it passes all tests over the 
day i'll send it to Linus in about 12 hours.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/