DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=VGoPuTO01Q+QHw2bJiVsY/zVIdiTRAp0a+LmwkFiOfht4W9uDxVwffLMaTt5jENxkF/vgGLPtdcQGk56cbfa364r/iiE02xV9SqC1wTNYdJ5LfFB1cLOpvovlnnlvyDIeUShfaXjl5HZCplVDKpoyF8d/ty5VJC4Fp1kZ10AOvQ=
Message-ID: <e9e943910803081040n78898f20t66a5f8396e63acbe@mail.gmail.com>
Date: Sat, 8 Mar 2008 18:40:30 +0000
From: "Duane Griffin" <duaneg@dghda.com>
To: "Christoph Hellwig" <hch@infradead.org>
Subject: Re: [RFC, PATCH 4/6] jbd: refactor nested journal log recovery loop into separate functions
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
       "Theodore Tso" <tytso@mit.edu>, sct@redhat.com,
       akpm@linux-foundation.org, adilger@clusterfs.com
In-Reply-To: <20080308145351.GB18522@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <a047dfbd7855d5f484ae8a3434f6a073302505be.1204685366.git.duaneg@dghda.com>
	 <8644b32ddec999bbc1da0ac55ad7b66d0b8176de.1204685366.git.duaneg@dghda.com>
	 <20080308145351.GB18522@infradead.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 861
Lines: 25

On 08/03/2008, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Mar 06, 2008 at 01:59:12AM +0000, Duane Griffin wrote:
>  > +static int replay_data_block(
>  > +     journal_t *journal, struct buffer_head *obh, char *data,
>  > +     int flags, unsigned long blocknr)
>
> quite odd formatting, this should be more like:
>
>  static int replay_data_block(journal_t *journal, struct buffer_head *obh,
>                 char *data, int flags, unsigned long blocknr)
>
> (same for the other new helpers)

OK, will change.

Thanks,
Duane.

-- 
"I never could learn to drink that blood and call it wine" - Bob Dylan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/