Date: Sun, 9 Mar 2008 09:58:02 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Dave Young" <hidave.darkstar@gmail.com>
Cc: "Johannes Weiner" <hannes@saeurebad.de>, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] add time_now_after and other macros which compare
 with jiffies
Message-ID: <20080309095802.70d91c7b@core>
In-Reply-To: <a8e1da0803081654l50fdda44jbbed1d1ed2caf9ae@mail.gmail.com>
References: <200803080735.06984.hidave.darkstar@gmail.com>
	<877igd6vqn.fsf@saeurebad.de>
	<a8e1da0803081654l50fdda44jbbed1d1ed2caf9ae@mail.gmail.com>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1081
Lines: 25

> >  > +/* time_now_before_eq(a) return true if now (jiffies) is before or equal to a */
> >  > +#define time_now_before_eq(a) time_before_eq(jiffies, a)
> >
> >  How about even more obvious names like time_is_past(), time_is_future(),
> >  ...?
> 
> Thanks for comment.
> 
> Then how do we name the _eq version?  IMHO, the time_now_* is enough.

Why do you even need them. I don't see the point of *any* of these extra
macros as they simply obfuscate code and hide what is actually going on.
The initial macros were added because of the type safety and correct
comparison rules being complex. They have a purpose.

Even if you want these you can use !time_future() if you don't want the
_eq variants. Generally speaking drivers should be using timers not
polled loops, and most of our loops comparing with jiffies want removing.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/