Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754869AbYCJCD6 (ORCPT ); Sun, 9 Mar 2008 22:03:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754481AbYCJCDt (ORCPT ); Sun, 9 Mar 2008 22:03:49 -0400 Received: from wr-out-0506.google.com ([64.233.184.227]:49412 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754489AbYCJCDs (ORCPT ); Sun, 9 Mar 2008 22:03:48 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Fawwqo8UwvnXFc/a/kXFaGPWGVO/uLqMxpUx8OLOsIjeOBir01j1XYMO5pp/nyycJzQsRWN9qNQMvGciy3fDnmwiHLH/CXJoQD+3RK2ZIE/syOi4EYsyAeF2SUdCQGpZAC4tqvU38xlyYjYCLSBf+HCaXlvKdE7nW4Hy8CUSdCo= Message-ID: Date: Mon, 10 Mar 2008 10:03:47 +0800 From: "Dave Young" To: "Andrew Morton" Subject: Re: [PATCH v2] add time_now_after and other macros which compare with jiffies Cc: "Alan Cox" , "Johannes Weiner" , linux-kernel@vger.kernel.org In-Reply-To: <20080309120133.2d1363e4.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200803080735.06984.hidave.darkstar@gmail.com> <877igd6vqn.fsf@saeurebad.de> <20080309095802.70d91c7b@core> <20080309110808.2249aa3a@core> <20080309120133.2d1363e4.akpm@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 26 On Mon, Mar 10, 2008 at 3:01 AM, Andrew Morton wrote: > On Sun, 9 Mar 2008 11:08:08 +0000 Alan Cox wrote: > > > > Yes, This has a purpose as well. You will find most of the usage of these > > > macros are just compare some value with jiffies after doing some grep. > > > > That is no reason to add more macros that hide how they do it, or make > > jiffies itself invisible to the grep search or variable usage finding > > tools (and for tickless that very thing is important) > > We could call them time_is_after_jiffies(), time_is_before_jiffies(), etc. > > Those names are actually better than time_after_now(), etc. > > Andrew, Hannes, Alan, thanks for your comment, I have send the new time_is_* patch as v3. Hannes, It's more like your is_past/is_future but looks better when along with _eq -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/