Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754518AbYCJCp7 (ORCPT ); Sun, 9 Mar 2008 22:45:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751095AbYCJCpw (ORCPT ); Sun, 9 Mar 2008 22:45:52 -0400 Received: from gw.goop.org ([64.81.55.164]:55531 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750984AbYCJCpv (ORCPT ); Sun, 9 Mar 2008 22:45:51 -0400 Message-ID: <47D4A0B7.10905@goop.org> Date: Sun, 09 Mar 2008 19:45:11 -0700 From: Jeremy Fitzhardinge User-Agent: Thunderbird 2.0.0.12 (X11/20080226) MIME-Version: 1.0 To: Linus Torvalds CC: Ingo Molnar , Arjan van de Ven , hans.rosenfeld@amd.com, linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , Jan Beulich Subject: Re: bisected boot regression post 2.6.25-rc3.. please revert References: <20080301105646.2c8620d9@laptopd505.fenrus.org> <20080303074620.GC5934@elte.hu> <20080303091304.GA17911@elte.hu> <47CC2A3D.1000307@linux.intel.com> <20080303174009.GA19131@elte.hu> <47CC451A.2060501@linux.intel.com> <20080309115603.GA951@elte.hu> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 27 Linus Torvalds wrote: > So I would *very* strongly instead argue: > > - "unsigned long" is the native kernel type for all address manipulation, > and thus "PAGE_SIZE" and "PAGE_MASK" should continue to have that type. > > - anything that uses any other type without explicitly making sure it's > safe is mis-using those macros. IOW, PAGE_MASk was *never* a type that > had anything what-so-ever to do with page table entry bits, and this is > purely a page table entry issue! > Yes. PTE_MASK already exists for masking the address bits out of a pte. It should have the type pteval_t, which will deal with the PAE case cleanly. It should also only have the middle pfn bits set, so that _PAGE_NX is also not included. It's currently defined in terms of PHYSICAL_PAGE_MASK, which 1) is only used to define PTE_MASK, and 2) defined (wrongly) in terms of PAGE_MASK (though __PHYSICAL_MASK is correctly defined). J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/