Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbYCJSs5 (ORCPT ); Mon, 10 Mar 2008 14:48:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751492AbYCJSsu (ORCPT ); Mon, 10 Mar 2008 14:48:50 -0400 Received: from saeurebad.de ([85.214.36.134]:33855 "EHLO saeurebad.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751366AbYCJSst (ORCPT ); Mon, 10 Mar 2008 14:48:49 -0400 From: Johannes Weiner To: Hugh Dickins Cc: Ingo Molnar , Linux Kernel Mailing List Subject: Re: [PATCH] x86: Remove redundant display of free swap space in show_mem() References: <87abl68rdd.fsf@saeurebad.de> Date: Mon, 10 Mar 2008 19:47:02 +0100 In-Reply-To: (Hugh Dickins's message of "Mon, 10 Mar 2008 17:28:37 +0000 (GMT)") Message-ID: <87wsoa76xl.fsf@saeurebad.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 27 Hi, Hugh Dickins writes: > On Mon, 10 Mar 2008, Johannes Weiner wrote: >> From: Johannes Weiner >> >> show_free_areas() already displays free swap space, no need to do it a >> second time in show_mem() which calls the former anyway. >> >> Signed-off-by: Johannes Weiner > > I heartily approve of this; and yes, it's the per-arch one which should > go (since its "alignment" looks nasty). But there's a lot more arches > than just x86 which should be fixed (and so rather more work, preparing > those patches for the various maintainers) - is that something you'd > have time to do? (Don't worry, "No" is a perfectly fair answer, and > it's no way essential that all change at once.) Yes, I will whip something up. Thanks for the feedback. Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/