Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757483AbYCKCTl (ORCPT ); Mon, 10 Mar 2008 22:19:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754493AbYCKCTe (ORCPT ); Mon, 10 Mar 2008 22:19:34 -0400 Received: from mx1.redhat.com ([66.187.233.31]:41904 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754241AbYCKCTd (ORCPT ); Mon, 10 Mar 2008 22:19:33 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Oleg Nesterov X-Fcc: ~/Mail/linus Cc: Ingo Molnar , Andrew Morton , Arjan van de Ven , linux-kernel@vger.kernel.org Subject: Re: [RFC, PATCH] signals: print_fatal_signal: fix the signr "calculation" In-Reply-To: Oleg Nesterov's message of Sunday, 9 March 2008 19:11:53 +0300 <20080309161153.GA76@tv-sign.ru> References: <20080308172453.GA28323@tv-sign.ru> <20080308190311.779B326F990@magilla.localdomain> <20080309110511.GA18128@elte.hu> <20080309161153.GA76@tv-sign.ru> X-Antipastobozoticataclysm: When George Bush projectile vomits antipasto on the Japanese. Message-Id: <20080311021928.B725E26F991@magilla.localdomain> Date: Mon, 10 Mar 2008 19:19:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 19 > For various reasons we can't currently do the same for sig_kernel_coredump() > signals. But, when rlim[RLIMIT_CORE] == 0, we don't actually need coredumping? > So, we could do something like > > > - if (!sig_kernel_coredump(sig)) { > + if (!sig_kernel_coredump(sig) || !signal->rlim[RLIMIT_CORE]) { I don't like this. I think it's better to leave logic like RLIMIT_CORE checks to the core dump code itself. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/