Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757746AbYCKCUg (ORCPT ); Mon, 10 Mar 2008 22:20:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751458AbYCKCU3 (ORCPT ); Mon, 10 Mar 2008 22:20:29 -0400 Received: from mx1.redhat.com ([66.187.233.31]:41917 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754493AbYCKCU2 (ORCPT ); Mon, 10 Mar 2008 22:20:28 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Oleg Nesterov X-Fcc: ~/Mail/linus Cc: Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH] signals: cleanup the usage of print_fatal_signal() In-Reply-To: Oleg Nesterov's message of Tuesday, 11 March 2008 00:17:44 +0300 <20080310211744.GA1580@tv-sign.ru> References: <20080310211744.GA1580@tv-sign.ru> X-Shopping-List: (1) Famous cheese cushions (2) Benevolent comical dividers (3) Delicious crossword aggressors (4) Satirical division condensers Message-Id: <20080311022024.941AD26F991@magilla.localdomain> Date: Mon, 10 Mar 2008 19:20:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 370 Lines: 11 Looks right to me. I'd prefer to see a comment before the added lines and a blank line after them, though. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/