Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755902AbYCKGah (ORCPT ); Tue, 11 Mar 2008 02:30:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751323AbYCKGa1 (ORCPT ); Tue, 11 Mar 2008 02:30:27 -0400 Received: from adsl-67-113-118-6.dsl.sndg02.pacbell.net ([67.113.118.6]:42534 "EHLO multivac.one-eyed-alien.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbYCKGa0 (ORCPT ); Tue, 11 Mar 2008 02:30:26 -0400 Date: Mon, 10 Mar 2008 23:30:19 -0700 From: Matthew Dharm To: Constantin Baranov Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.25-rc4] usb: add support for Motorola ROKR Z6 cellphone in mass storage mode Message-ID: <20080311063019.GA1756@one-eyed-alien.net> Mail-Followup-To: Constantin Baranov , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <47D5804A.2020000@const.mimas.ru> <20080310190158.GI2820@one-eyed-alien.net> <47D59173.9000902@const.mimas.ru> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: <47D59173.9000902@const.mimas.ru> User-Agent: Mutt/1.4.2.3i Organization: One Eyed Alien Networks X-Copyright: (C) 2008 Matthew Dharm, all rights reserved. X-Message-Flag: Get a real e-mail client. http://www.mutt.org/ X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.1.12 (multivac.one-eyed-alien.net [127.0.0.1]); Mon, 10 Mar 2008 23:30:20 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5359 Lines: 142 --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable One last question: If it's a ROKR Z6, why does the string in unusual_devs.h say "MSnc."? Matt On Mon, Mar 10, 2008 at 11:52:19PM +0400, Constantin Baranov wrote: > Yes. These three flags corresponds to three different bugs > discussed in linux-usb-users@lists.sourceforge.net > (http://www.mail-archive.com/linux-usb-users@lists.sourceforge.net/msg191= 67.html) >=20 > FIX_INQUIRY: Device always sends PQ=3D1 in inquiry data, so SCSI subsystem > stops to create sd device. > FIX_CAPACITY: Device tells wrong size of internal memory card > (real size + 1). If one would try to read/write "phantom" sector then > phone hang up and reboot. > BULK_IGNORE_TAG: Sometimes device sends wrong tags causing computer to > reset endpoint. This may corrupt phone's filesystem in particular. >=20 > Matthew Dharm wrote: > > Are all 3 flags truly needed? > >=20 > > Matt > >=20 > > On Mon, Mar 10, 2008 at 10:39:06PM +0400, Constantin Baranov wrote: > >> From: Constantin Baranov > >> > >> Motorola ROKR Z6 cellphone has bugs in its USB, so it is impossible to= use > >> it as mass storage. Patch describes new "unusual" USB device for it wi= th > >> FIX_INQUIRY and FIX_CAPACITY flags and new BULK_IGNORE_TAG flag. > >> Last flag relaxes check for equality of bcs->Tag and us->tag in > >> usb_stor_Bulk_transport routine. > >> > >> Signed-off-by: Constantin Baranov > >> --- > >> drivers/usb/storage/transport.c | 3 ++- > >> drivers/usb/storage/unusual_devs.h | 10 ++++++++++ > >> include/linux/usb_usual.h | 4 +++- > >> 3 files changed, 15 insertions(+), 2 deletions(-) > >> > >> diff -upr linux-2.6.25-rc4/drivers/usb/storage/transport.c > >> linux-2.6.25-rc4-motorokr_z6/drivers/usb/storage/transport.c > >> --- linux-2.6.25-rc4/drivers/usb/storage/transport.c 2008-03-10 > >> 22:09:11.000000000 +0400 > >> +++ linux-2.6.25-rc4-motorokr_z6/drivers/usb/storage/transport.c > >> 2008-03-10 22:11:24.000000000 +0400 > >> @@ -1009,7 +1009,8 @@ int usb_stor_Bulk_transport(struct scsi_ > >> US_DEBUGP("Bulk Status S 0x%x T 0x%x R %u Stat 0x%x\n", > >> le32_to_cpu(bcs->Signature), bcs->Tag, > >> residue, bcs->Status); > >> - if (bcs->Tag !=3D us->tag || bcs->Status > US_BULK_STAT_PHASE) { > >> + if (!(bcs->Tag =3D=3D us->tag || (us->flags & US_FL_BULK_IGNORE_TAG)= ) || > >> + bcs->Status > US_BULK_STAT_PHASE) { > >> US_DEBUGP("Bulk logical error\n"); > >> return USB_STOR_TRANSPORT_ERROR; > >> } > >> diff -upr linux-2.6.25-rc4/drivers/usb/storage/unusual_devs.h > >> linux-2.6.25-rc4-motorokr_z6/drivers/usb/storage/unusual_devs.h > >> --- linux-2.6.25-rc4/drivers/usb/storage/unusual_devs.h 2008-03-10 > >> 22:09:11.000000000 +0400 > >> +++ linux-2.6.25-rc4-motorokr_z6/drivers/usb/storage/unusual_devs.h > >> 2008-03-10 22:10:40.000000000 +0400 > >> @@ -1589,6 +1589,16 @@ UNUSUAL_DEV( 0x22b8, 0x4810, 0x0001, 0x > >> US_SC_DEVICE, US_PR_DEVICE, NULL, > >> US_FL_FIX_CAPACITY), > >> > >> +/* > >> + * Patch by Constantin Baranov > >> + * Report by Andreas Koenecke > >> + */ > >> +UNUSUAL_DEV( 0x22b8, 0x6426, 0x0101, 0x0101, > >> + "Motorola", > >> + "MSnc.", > >> + US_SC_DEVICE, US_PR_DEVICE, NULL, > >> + US_FL_FIX_INQUIRY | US_FL_FIX_CAPACITY | US_FL_BULK_IGNORE_TAG), > >> + > >> /* Reported by Radovan Garabik */ > >> UNUSUAL_DEV( 0x2735, 0x100b, 0x0000, 0x9999, > >> "MPIO", > >> diff -upr linux-2.6.25-rc4/include/linux/usb_usual.h > >> linux-2.6.25-rc4-motorokr_z6/include/linux/usb_usual.h > >> --- linux-2.6.25-rc4/include/linux/usb_usual.h 2008-03-10 > >> 22:09:12.000000000 +0400 > >> +++ linux-2.6.25-rc4-motorokr_z6/include/linux/usb_usual.h 2008-03-10 > >> 22:10:40.000000000 +0400 > >> @@ -50,7 +50,9 @@ > >> US_FLAG(CAPACITY_HEURISTICS, 0x00001000) \ > >> /* sometimes sizes is too big */ \ > >> US_FLAG(MAX_SECTORS_MIN,0x00002000) \ > >> - /* Sets max_sectors to arch min */ > >> + /* Sets max_sectors to arch min */ \ > >> + US_FLAG(BULK_IGNORE_TAG,0x00004000) \ > >> + /* Ignore tag mismatch in bulk operations */ > >> > >> > >> #define US_FLAG(name, value) US_FL_##name =3D value , > >> > >> -- > >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in > >> the body of a message to majordomo@vger.kernel.org > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >=20 --=20 Matthew Dharm Home: mdharm-usb@one-eyed-alien.= net=20 Maintainer, Linux USB Mass Storage Driver G: Money isn't everything, A.J. AJ: Who convinced you of that? G: The Chief, at my last salary review. -- Mike and Greg User Friendly, 11/3/1998 --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFH1ib7HL9iwnUZqnkRAoAAAJ9q5OBsX70ZwmA2XmybCLWac/YScACfQQlK FAo/Ro3uXzKpt7/RgHSppeA= =oh0l -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/