Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755173AbYCKHGz (ORCPT ); Tue, 11 Mar 2008 03:06:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750925AbYCKHGs (ORCPT ); Tue, 11 Mar 2008 03:06:48 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:38428 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750874AbYCKHGr (ORCPT ); Tue, 11 Mar 2008 03:06:47 -0400 Date: Tue, 11 Mar 2008 00:06:19 -0700 From: Andrew Morton To: Olof Johansson Cc: dan.j.williams@intel.com, shannon.nelson@intel.com, linux-kernel@vger.kernel.org, pasemi-linux@ozlabs.org, linuxppc-dev@ozlabs.org, hskinnemoen@atmel.com Subject: Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine Message-Id: <20080311000619.ba39311f.akpm@linux-foundation.org> In-Reply-To: <20080306233900.GA3969@lixom.net> References: <20080306233900.GA3969@lixom.net> X-Mailer: Sylpheed 2.3.1 (GTK+ 2.10.11; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2365 Lines: 42 On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson wrote: > pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine > > First cut at a dma copy offload driver for PA Semi PWRficient. It uses the > platform-specific functions to allocate channels, etc. Applied this on Paul's latest and powerpc allmodconfig goes boom. drivers/dma/pasemi_dma.c: In function `pasemi_dma_alloc_chan_resources': drivers/dma/pasemi_dma.c:152: error: `PAS_DMA_TXCHAN_CFG_TY_COPY' undeclared (first use in this function) drivers/dma/pasemi_dma.c:152: error: (Each undeclared identifier is reported only once drivers/dma/pasemi_dma.c:152: error: for each function it appears in.) drivers/dma/pasemi_dma.c:154: error: `PAS_DMA_TXCHAN_CFG_LPDQ' undeclared (first use in this function) drivers/dma/pasemi_dma.c:155: error: `PAS_DMA_TXCHAN_CFG_LPSQ' undeclared (first use in this function) drivers/dma/pasemi_dma.c: In function `pasemi_dma_probe': drivers/dma/pasemi_dma.c:394: error: structure has no member named `device_dependency_added' Also this driver from git-md-accel is pretty sick: drivers/dma/fsldma.c:439: warning: comparison of distinct pointer types lacks a cast drivers/dma/fsldma.c: In function `fsl_chan_xfer_ld_queue': drivers/dma/fsldma.c:584: warning: long long unsigned int format, dma_addr_t arg (arg 4) drivers/dma/fsldma.c: In function `fsl_dma_chan_do_interrupt': drivers/dma/fsldma.c:661: warning: unsigned int format, different type arg (arg 5) drivers/dma/fsldma.c:677: warning: long long unsigned int format, dma_addr_t arg (arg 4) drivers/dma/fsldma.c:677: warning: long long unsigned int format, dma_addr_t arg (arg 5) drivers/dma/fsldma.c:694: warning: unsigned int format, different type arg (arg 4) drivers/dma/fsldma.c: In function `fsl_dma_self_test': drivers/dma/fsldma.c:833: warning: int format, different type arg (arg 5) drivers/dma/fsldma.c: In function `of_fsl_dma_probe': drivers/dma/fsldma.c:1003: warning: unsigned int format, different type arg (arg 5) drivers/dma/fsldma.c: At top level: drivers/dma/fsldma.c:723: warning: 'fsl_dma_callback_test' defined but not used -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/