Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757562AbYCKPXc (ORCPT ); Tue, 11 Mar 2008 11:23:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752626AbYCKPXY (ORCPT ); Tue, 11 Mar 2008 11:23:24 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:46048 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341AbYCKPXX (ORCPT ); Tue, 11 Mar 2008 11:23:23 -0400 Date: Tue, 11 Mar 2008 16:23:03 +0100 From: Ingo Molnar To: Alexander van Heukelum Cc: Alexander van Heukelum , Andi Kleen , Thomas Gleixner , "H. Peter Anvin" , LKML Subject: Re: [PATCH] x86: Optimize find_next_(zero_)bit for small constant-size bitmaps Message-ID: <20080311152303.GA21530@elte.hu> References: <20080309200103.GA895@mailshack.com> <20080309201152.GB28454@elte.hu> <1205094704.6430.1241420859@webmail.messagingengine.com> <20080309205132.GA9021@elte.hu> <20080310231724.GA8370@mailshack.com> <20080311095631.GT25110@elte.hu> <20080311151719.GA15313@mailshack.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080311151719.GA15313@mailshack.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 24 * Alexander van Heukelum wrote: > > > +#endif /* CONFIG_GENERIC_FIND_NEXT_BIT */ > > > > there should be an #else here i think, which maps find_next_bit to > > __find_next_bit / etc. > > No, that is intentional: architectures are expected to either set > CONFIG_GENERIC_FIND_NEXT_BIT, or provide their own implementation of > find_next_bit. indeed, you are right. > This version runs fine on qemu. great - i've queued it up into x86.git. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/