Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754727AbYCKSPl (ORCPT ); Tue, 11 Mar 2008 14:15:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753606AbYCKSPN (ORCPT ); Tue, 11 Mar 2008 14:15:13 -0400 Received: from mga03.intel.com ([143.182.124.21]:58589 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753407AbYCKSPL (ORCPT ); Tue, 11 Mar 2008 14:15:11 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.25,481,1199692800"; d="scan'208";a="217382494" Subject: Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine From: Dan Williams To: Andrew Morton Cc: Olof Johansson , "Nelson, Shannon" , linux-kernel@vger.kernel.org, pasemi-linux@ozlabs.org, linuxppc-dev@ozlabs.org, hskinnemoen@atmel.com In-Reply-To: <20080311105355.64a9c380.akpm@linux-foundation.org> References: <20080306233900.GA3969@lixom.net> <20080311000619.ba39311f.akpm@linux-foundation.org> <20080311142545.GA18843@lixom.net> <20080311105355.64a9c380.akpm@linux-foundation.org> Content-Type: text/plain Date: Tue, 11 Mar 2008 11:15:11 -0700 Message-Id: <1205259311.26723.40.camel@dwillia2-linux.ch.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 (2.10.3-8.fc7) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3825 Lines: 83 On Tue, 2008-03-11 at 10:53 -0700, Andrew Morton wrote: > On Tue, 11 Mar 2008 09:25:45 -0500 > Olof Johansson wrote: > > > On Tue, Mar 11, 2008 at 12:06:19AM -0700, Andrew Morton wrote: > > > On Thu, 6 Mar 2008 17:39:00 -0600 Olof Johansson wrote: > > > > > > > pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine > > > > > > > > First cut at a dma copy offload driver for PA Semi PWRficient. It uses the > > > > platform-specific functions to allocate channels, etc. > > > > > > Applied this on Paul's latest and powerpc allmodconfig goes boom. > > > > It's dependent on my latest pull request of pasemi.git for-2.6.26 that > > Paul hasn't pulled/pushed yet. > > Maybe we should get that tree into -mm and/or linux-next. > > People do test -mm on powerpc. > > > > drivers/dma/pasemi_dma.c: In function `pasemi_dma_alloc_chan_resources': > > > drivers/dma/pasemi_dma.c:152: error: `PAS_DMA_TXCHAN_CFG_TY_COPY' undeclared (first use in this function) > > > drivers/dma/pasemi_dma.c:152: error: (Each undeclared identifier is reported only once > > > drivers/dma/pasemi_dma.c:152: error: for each function it appears in.) > > > drivers/dma/pasemi_dma.c:154: error: `PAS_DMA_TXCHAN_CFG_LPDQ' undeclared (first use in this function) > > > drivers/dma/pasemi_dma.c:155: error: `PAS_DMA_TXCHAN_CFG_LPSQ' undeclared (first use in this function) > > > drivers/dma/pasemi_dma.c: In function `pasemi_dma_probe': > > > drivers/dma/pasemi_dma.c:394: error: structure has no member named `device_dependency_added' > > > > .. and that one is caused by recent changes in async_tx.git. I was > > waiting on other review comments from the DMA maintainers before > > resubmitting; timer has expired though and I'll do it anyway today. > > What is async_tx.git? I recently moved the async_tx git tree to kernel.org. I gave a heads up [1]. Here is the reasoning: For -mm please replace the 'git-md-accel' url with the following, it should also be renamed to 'git-async-tx' as anything that impacts MD will go through Neil. git://git.kernel.org/pub/scm/linux/kernel/git/djbw/async_tx.git upstream > > > Also this driver from git-md-accel is pretty sick: > > > > > > > > > drivers/dma/fsldma.c:439: warning: comparison of distinct pointer types lacks a cast > > > drivers/dma/fsldma.c: In function `fsl_chan_xfer_ld_queue': > > > drivers/dma/fsldma.c:584: warning: long long unsigned int format, dma_addr_t arg (arg 4) > > > drivers/dma/fsldma.c: In function `fsl_dma_chan_do_interrupt': > > > drivers/dma/fsldma.c:661: warning: unsigned int format, different type arg (arg 5) > > > drivers/dma/fsldma.c:677: warning: long long unsigned int format, dma_addr_t arg (arg 4) > > > drivers/dma/fsldma.c:677: warning: long long unsigned int format, dma_addr_t arg (arg 5) > > > drivers/dma/fsldma.c:694: warning: unsigned int format, different type arg (arg 4) > > > drivers/dma/fsldma.c: In function `fsl_dma_self_test': > > > drivers/dma/fsldma.c:833: warning: int format, different type arg (arg 5) > > > drivers/dma/fsldma.c: In function `of_fsl_dma_probe': > > > drivers/dma/fsldma.c:1003: warning: unsigned int format, different type arg (arg 5) > > > drivers/dma/fsldma.c: At top level: > > > drivers/dma/fsldma.c:723: warning: 'fsl_dma_callback_test' defined but not used > > > > Yeah, Zhang Wei posted a patch for that on lkml yesterday. > > OK. My fault for not pushing out this cleanup to the old url while the git-md-accel changeover was pending. -- Dan [1] http://marc.info/?l=linux-kernel&m=120465351720649&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/