Date: Tue, 11 Mar 2008 21:36:06 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] signals: document CLD_CONTINUED notification mechanics
Message-ID: <20080311183606.GE586@tv-sign.ru>
References: <20080309215338.GA2296@tv-sign.ru> <20080311021741.A863826F991@magilla.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080311021741.A863826F991@magilla.localdomain>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 820
Lines: 25

(surprisingly, this is rather important issue for me ;)

On 03/10, Roland McGrath wrote:
>
> >  		if (why) {
> > +			/* The first thread which returns from finish_stop()
> 
> Canonical style is:
> 
> 			/*
> 			 * The first thread that returns from finish_stop()

Yes, I know. But the latter needs an extra line! Don't get me wrong, I am
not worrying about the result of `wc ...`, and I often add the blank lines
to improve the readability. But since the comment block itself adds the
"space", why should we lessen the number of the code lines visible to the
reader?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/