Date: Tue, 11 Mar 2008 22:09:47 +0100
From: Wim Van Sebroeck <wim@iguana.be>
To: Samuel Tardieu <sam@rfc1149.net>
Cc: =?iso-8859-1?Q?P=E1draig?= Brady <P@draigBrady.com>, junker@anduras.de,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: w83697hf_wdt.c stops watchdog on load
Message-ID: <20080311210947.GF7505@infomag.infomag.iguana.be>
References: <47D564CA.1040507@draigBrady.com> <2008-03-10-18-48-16+trackit+sam@rfc1149.net> <47D5C1DC.6080808@draigBrady.com> <20080311202214.GA7505@infomag.infomag.iguana.be> <2008-03-11-21-28-21+trackit+sam@rfc1149.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2008-03-11-21-28-21+trackit+sam@rfc1149.net>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 942
Lines: 23

Hi Sam,

> That was my intent: disable the watchdog by default, and add an option
> not to disable it (let it untouched, so getting the BIOS setting) at
> module initialization, as P?draig request is totally reasonable.

Ok, then we are on the same line. It indeed makes sense to do this
with watchdog devices that are capable of being controlled by the
bios and where the timeout/keepalive time can be set big enough.

What should also be looked at is when you take over the watchdog
settings from the bios, do you then take the same timeout/keepalive
value? In the pcwd-drivers I took the dip-switch value of the card
when the value was 0. You could do something similar here.

Greetings,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/