Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751929AbYCLBcV (ORCPT ); Tue, 11 Mar 2008 21:32:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750968AbYCLBcM (ORCPT ); Tue, 11 Mar 2008 21:32:12 -0400 Received: from byss.tchmachines.com ([208.76.80.75]:58819 "EHLO byss.tchmachines.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbYCLBcM (ORCPT ); Tue, 11 Mar 2008 21:32:12 -0400 X-Greylist: delayed 4885 seconds by postgrey-1.27 at vger.kernel.org; Tue, 11 Mar 2008 21:32:11 EDT Date: Tue, 11 Mar 2008 17:10:40 -0700 From: Ravikiran G Thirumalai To: Jeremy Fitzhardinge Cc: Randy Dunlap , Andrew Morton , virtualization@lists.osdl.org, linux-kernel@vger.kernel.org, Glauber de Oliveira Costa , shai@scalex86.org Subject: Re: 2.6.25-rc5-mm1 (paravirt/vsmp/no PCI) Message-ID: <20080312001040.GA6434@localdomain> References: <20080311011434.ad8c8d7d.akpm@linux-foundation.org> <20080311100955.ca113f90.randy.dunlap@oracle.com> <47D6CD04.8060303@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47D6CD04.8060303@goop.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - byss.tchmachines.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - scalex86.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2181 Lines: 70 On Tue, Mar 11, 2008 at 11:18:44AM -0700, Jeremy Fitzhardinge wrote: >Randy Dunlap wrote: > >Added Cc: > >>On Tue, 11 Mar 2008 01:14:34 -0700 Andrew Morton wrote: >> >> >>>ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-rc5/2.6.25-rc5-mm1/ >>> >> >>randconfig (x86_64) with >>PCI=n >>PARAVIRT=y >>VSMP=n >> >>ends with >> >>arch/x86/kernel/built-in.o: In function `is_vsmp_box': >>(.text+0x1178d): undefined reference to `early_pci_allowed' >>arch/x86/kernel/built-in.o: In function `is_vsmp_box': >>(.text+0x117a9): undefined reference to `read_pci_config' >>arch/x86/kernel/built-in.o: In function `vsmp_init': >>(.init.text+0x4fcc): undefined reference to `early_pci_allowed' >>arch/x86/kernel/built-in.o: In function `vsmp_init': >>(.init.text+0x501a): undefined reference to `read_pci_config' >>make[1]: *** [.tmp_vmlinux1] Error 1 >> >>config attached. > > J Would anyone have objection to have PARAVIRT depend on PCI, since the vsmp paravirt bits depend on PCI cfg space to determine if the system is vsmp? If not, this patch would suffice. Glauber? Thanks, Kiran --- Make PARAVIRT depend on PCI. vSMP PARAVIRT ops probe the pci config space to determine if the system is indeed a ScaleMP vSMP box. Hence, depend on PCI to enable PARAVIRT. Signed-off-by: Ravikiran Thirumalai Index: linux-2.6.24/arch/x86/Kconfig =================================================================== --- linux-2.6.24.orig/arch/x86/Kconfig 2008-03-11 16:38:26.000000000 -0700 +++ linux-2.6.24/arch/x86/Kconfig 2008-03-11 16:50:52.000000000 -0700 @@ -384,7 +384,7 @@ source "arch/x86/lguest/Kconfig" config PARAVIRT bool "Enable paravirtualization code" - depends on !(X86_VISWS || X86_VOYAGER) + depends on !(X86_VISWS || X86_VOYAGER) && PCI help This changes the kernel so it can modify itself when it is run under a hypervisor, potentially improving performance significantly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/