Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbYCLJWm (ORCPT ); Wed, 12 Mar 2008 05:22:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751201AbYCLJWd (ORCPT ); Wed, 12 Mar 2008 05:22:33 -0400 Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:54608 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbYCLJWc (ORCPT ); Wed, 12 Mar 2008 05:22:32 -0400 Date: Wed, 12 Mar 2008 10:22:26 +0100 From: Sebastian Siewior To: "Huang, Ying" Cc: Herbert Xu , "Adam J. Richter" , Alexander Kjeldaas , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH -mm crypto] AES: remove crypto_fl_tab and replace crypto_il_tab with isb_tab Message-ID: <20080312092226.GA32150@Chamillionaire.breakpoint.cc> Reply-To: Sebastian Siewior References: <1205210576.3676.7.camel@caritas-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1205210576.3676.7.camel@caritas-dev.intel.com> X-Key-Id: FE3F4706 X-Key-Fingerprint: FFDA BBBB 3563 1B27 75C9 925B 98D5 5C1C FE3F 4706 User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 725 Lines: 20 * Huang, Ying | 2008-03-11 12:42:56 [+0800]: >Remove crypto_fl_tab from aes implementation. Because mix_col(1,n) = n, >all information in cryto_fl_tab is in crypto_ft_tab too. >crypto_il_tab is replaced by isb_tab, the byte shift is done >during decryption. nice. >This patch is only for generic C implementation. If this kind of idea >is desired, I will implement the ASM version for x86. Could you please run | modprobe tcrypt mode=200 with and without the patch? Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/