Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753917AbYCLMeT (ORCPT ); Wed, 12 Mar 2008 08:34:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751420AbYCLMeA (ORCPT ); Wed, 12 Mar 2008 08:34:00 -0400 Received: from x346.tv-sign.ru ([89.108.83.215]:39759 "EHLO mail.screens.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbYCLMd6 (ORCPT ); Wed, 12 Mar 2008 08:33:58 -0400 Date: Wed, 12 Mar 2008 15:33:29 +0300 From: Oleg Nesterov To: Andrew Morton Cc: Ingo Molnar , Pavel Emelyanov , Roland McGrath , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] signals: document CLD_CONTINUED notification mechanics Message-ID: <20080312123329.GA13481@tv-sign.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 33 A couple of small comments about how CLD_CONTINUED notification works. Signed-off-by: Oleg Nesterov --- 25/kernel/signal.c~2_DOC_NOTIFY 2008-03-12 13:29:42.000000000 +0300 +++ 25/kernel/signal.c 2008-03-12 15:16:52.000000000 +0300 @@ -630,6 +630,11 @@ static int prepare_signal(int sig, struc why |= SIGNAL_CLD_STOPPED; if (why) { + /* + * The first thread which returns from finish_stop() + * will take ->siglock, notice SIGNAL_CLD_MASK, and + * notify its parent. See get_signal_to_deliver(). + */ signal->flags = why | SIGNAL_STOP_CONTINUED; signal->group_stop_count = 0; signal->group_exit_code = 0; @@ -1652,7 +1657,7 @@ relock: try_to_freeze(); spin_lock_irq(&sighand->siglock); - + /* see prepare_signal(SIGCONT) */ if (unlikely(signal->flags & SIGNAL_CLD_MASK)) { int why = (signal->flags & SIGNAL_STOP_CONTINUED) ? CLD_CONTINUED : CLD_STOPPED; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/