Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751901AbYCLRvx (ORCPT ); Wed, 12 Mar 2008 13:51:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754672AbYCLRvk (ORCPT ); Wed, 12 Mar 2008 13:51:40 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:45421 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754656AbYCLRvi (ORCPT ); Wed, 12 Mar 2008 13:51:38 -0400 Subject: Re: [patch 09/10] Hugetlb common code update for System z. From: Dave Hansen To: Martin Schwidefsky Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Gerald Schaefer In-Reply-To: <20080312173218.186436562@de.ibm.com> References: <20080312173155.703966894@de.ibm.com> <20080312173218.186436562@de.ibm.com> Content-Type: text/plain Date: Wed, 12 Mar 2008 10:51:26 -0700 Message-Id: <1205344286.9828.91.camel@nimitz.home.sr71.net> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 33 On Wed, 2008-03-12 at 18:32 +0100, Martin Schwidefsky wrote: > +#ifndef ARCH_HAS_HUGE_PTE_TYPE > +#define huge_pte_none(pte) pte_none(pte) > +#define huge_pte_wrprotect(pte) pte_wrprotect(pte) > +#define huge_ptep_set_wrprotect(mm, addr, ptep) \ > + ptep_set_wrprotect(mm, addr, ptep) > +#define huge_ptep_set_access_flags(vma, addr, ptep, pte, dirty) \ > + ptep_set_access_flags(vma, addr, ptep, pte, dirty) > +#define huge_ptep_get(ptep) (*ptep) > +#endif > + > +#ifndef ARCH_HAS_PREPARE_HUGEPAGE Can you guys please do these defines in Kconfig instead of headers? I find them much easier to track down when I have one place to look, rather than a mess of 14 other #includes in a arch-specific header. :) I'm also a little concerned that you just #ifdef'd in about 44 new ptep functions in here. Have you carefully considered doing this in a way that would fit in better with the other architectures? > Huge ptes have a special type on s390 and cannot be handled with the > standard pte functions in certain cases. Can you elaborate a bit more on that? -- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/