Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752897AbYCLSwe (ORCPT ); Wed, 12 Mar 2008 14:52:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751665AbYCLSwX (ORCPT ); Wed, 12 Mar 2008 14:52:23 -0400 Received: from mail.vyatta.com ([216.93.170.194]:57073 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751545AbYCLSwW (ORCPT ); Wed, 12 Mar 2008 14:52:22 -0400 X-Spam-Flag: NO X-Spam-Score: -2.344 Date: Wed, 12 Mar 2008 11:52:15 -0700 From: Stephen Hemminger To: Krzysztof Halasa Cc: Jeff Garzik , Andrew Morton , , Subject: Re: [PATCH] Re: WAN: new PPP code for generic HDLC Message-ID: <20080312115215.5fb1a370@extreme> In-Reply-To: References: Organization: Vyatta X-Mailer: Claws Mail 3.3.0 (GTK+ 2.12.8; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 571 Lines: 21 > +struct hdlc_header { > + u8 address; > + u8 control; > + __be16 protocol; > +} __attribute__ ((packed)); > + > +struct cp_header { > + u8 code; > + u8 id; > + __be16 len; > +} __attribute__ ((packed)); > + If I remember correctly, the packed is unnecessary for structures like this and causes GCC to generate worse code. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/