Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755460AbYCLWDT (ORCPT ); Wed, 12 Mar 2008 18:03:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752858AbYCLWDH (ORCPT ); Wed, 12 Mar 2008 18:03:07 -0400 Received: from mx1.redhat.com ([66.187.233.31]:54811 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbYCLWDG (ORCPT ); Wed, 12 Mar 2008 18:03:06 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Oleg Nesterov X-Fcc: ~/Mail/linus Cc: Andrew Morton , Ingo Molnar , Pavel Emelyanov , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] signals: document CLD_CONTINUED notification mechanics In-Reply-To: Oleg Nesterov's message of Wednesday, 12 March 2008 15:33:29 +0300 <20080312123329.GA13481@tv-sign.ru> References: <20080312123329.GA13481@tv-sign.ru> X-Antipastobozoticataclysm: Bariumenemanilow Message-Id: <20080312220213.396DA26F992@magilla.localdomain> Date: Wed, 12 Mar 2008 15:02:13 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 670 Lines: 16 > A couple of small comments about how CLD_CONTINUED notification works. A worthy addition. I would make the get_signal_to_deliver comment say a little more. In particular, it's kind of nonobvious that though this happens at the beginning of the function, the importance of its placement is really that it will always be run (via the relock: loop) just after any wake-up from having been in TASK_STOPPED. Thanks, Roland -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/