Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754600AbYCLWMS (ORCPT ); Wed, 12 Mar 2008 18:12:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752279AbYCLWMD (ORCPT ); Wed, 12 Mar 2008 18:12:03 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:54260 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750959AbYCLWMB (ORCPT ); Wed, 12 Mar 2008 18:12:01 -0400 Date: Wed, 12 Mar 2008 23:12:00 +0100 (CET) From: Jan Engelhardt To: Krzysztof Halasa cc: Jeff Garzik , Andrew Morton , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] Re: WAN: new PPP code for generic HDLC In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 693 Lines: 17 On Mar 12 2008 21:10, Krzysztof Halasa wrote: > >> -static const char *code_names[CP_CODES] = {"0", "ConfReq", "ConfAck", >> +static const char *const code_names[] = {"0", "ConfReq", "ConfAck", >> "ConfNak", "ConfRej", "TermReq", >> "TermAck", "CodeRej", "ProtoRej", >> "EchoReq", "EchoReply", "Discard"}; > >The explicit sizes are there as a prevention. You can keep them if you need, the main issue was const anyway. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/