Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756480AbYCLXEI (ORCPT ); Wed, 12 Mar 2008 19:04:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753309AbYCLXDx (ORCPT ); Wed, 12 Mar 2008 19:03:53 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:58897 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756348AbYCLXDw (ORCPT ); Wed, 12 Mar 2008 19:03:52 -0400 Date: Wed, 12 Mar 2008 16:02:57 -0700 (PDT) From: Linus Torvalds To: Greg KH cc: "Rafael J. Wysocki" , Jeff Garzik , LKML , Adrian Bunk , Andrew Morton , Natalie Protasevich , Ingo Molnar , Len Brown , Guennadi Liakhovetski Subject: Re: pcibios_scanned needs to be set in ACPI? (was Re: 2.6.25-rc5: Reported regressions from 2.6.24) In-Reply-To: <20080312223431.GA24150@kroah.com> Message-ID: References: <200803110014.52985.rjw@sisk.pl> <47D6D61F.4050805@garzik.org> <200803112341.42517.rjw@sisk.pl> <20080312203205.GB17187@kroah.com> <20080312212704.GA16836@kroah.com> <20080312223431.GA24150@kroah.com> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 38 On Wed, 12 Mar 2008, Greg KH wrote: > > What happend in .25-rc was that we now catch these kinds of problems > (watching for duplicate kobjects to be registered and such.) So this > might have always been happening, but no warning was ever produced. It's not the warning that worries me. It's the apparent oops (keyboard leds blinking?) at shutdown/poweroff! > The reason we aren't shutting down is also due to the way kobjects now > work. If you don't clean up properly, they linger around and something > on the shutdown path (I haven't figured that out yet) doesn't want to > stop the machine. .. and that's my issue! We're too late in the game to try to figure things out and leave things hanging. The patch broke something, it needs to be fixed or reverted. It's been going on too long. I think it should have been reverted probably two weeks ago already. We can re-apply it early in the 2.6.26 series, and then try to fix it right. Since there is at least a patch worth trying now, I'll hold off reverting it and wait for Guennardi to test the patch, but the fact is, we shouldn't have a known-broken kernel for several weeks, when there is a known fix for it in reverting a single commit! We have _way_ too many regressions as it is. Regressions are bad. Ones that have known causes and haven't been fixed in three weeks are unacceptable. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/