Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbYCMEs0 (ORCPT ); Thu, 13 Mar 2008 00:48:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750764AbYCMEsR (ORCPT ); Thu, 13 Mar 2008 00:48:17 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37068 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750722AbYCMEsQ (ORCPT ); Thu, 13 Mar 2008 00:48:16 -0400 Date: Wed, 12 Mar 2008 21:47:52 -0700 (PDT) From: Linus Torvalds To: Johannes Weiner cc: Dave Young , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Marcin Slusarz , paulmck@linux.vnet.ibm.com Subject: Re: [PATCH -mm] do not check condition twice in WARN_ON_SECS In-Reply-To: <87pru0oxyv.fsf@saeurebad.de> Message-ID: References: <20080312010933.GA2957@darkstar.te-china.tietoenator.com> <87pru0oxyv.fsf@saeurebad.de> User-Agent: Alpine 1.00 (LFD 882 2007-12-20) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 467 Lines: 17 On Wed, 12 Mar 2008, Johannes Weiner wrote: > > What's wrong with: > > #define WARN_ON_SECS(condition, secs) \ > WARN_ON(condition && __ratelimit(secs * HZ, 1)) Add parenthesis around the arguments, please. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/