Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbYCMJtN (ORCPT ); Thu, 13 Mar 2008 05:49:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751656AbYCMJs7 (ORCPT ); Thu, 13 Mar 2008 05:48:59 -0400 Received: from mtagate7.de.ibm.com ([195.212.29.156]:50638 "EHLO mtagate7.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750807AbYCMJs6 (ORCPT ); Thu, 13 Mar 2008 05:48:58 -0400 Subject: Re: [patch 03/10] sched: add exported arch_reinit_sched_domains() to header file. From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, heiko.carstens@de.ibm.com In-Reply-To: <20080312160328.50cecd7f.akpm@linux-foundation.org> References: <20080312173155.703966894@de.ibm.com> <20080312173216.861331041@de.ibm.com> <20080312160328.50cecd7f.akpm@linux-foundation.org> Content-Type: text/plain Organization: IBM Corporation Date: Thu, 13 Mar 2008 10:48:52 +0100 Message-Id: <1205401732.26537.43.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 733 Lines: 24 On Wed, 2008-03-12 at 16:03 -0700, Andrew Morton wrote: > > +#if defined(CONFIG_SCHED_MC) || defined(CONFIG_SCHED_SMT) > > +extern int arch_reinit_sched_domains(void); > > +#endif > > I tend to recommend that the ifdefs be omitted here. > > It has the downside that the build will then fail at link-time rather than > at compile-time, but I haven't seen anyone complain about that. Ok, I've removed the #if. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/