Subject: Re: BUG: lock held when returning to user space
From: Daniel Walker <dwalker@mvista.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Kosina <jkosina@suse.cz>, Frank Munzert <frankm@linux.vnet.ibm.com>,
       mingo@elte.hu, linux-kernel@vger.kernel.org
In-Reply-To: <1205429946.8514.255.camel@twins>
References: <47D7FAA0.1090802@linux.vnet.ibm.com>
	 <Pine.LNX.4.64.0803122236030.7266@twin.jikos.cz>
	 <1205423029.10894.75.camel@localhost.localdomain>
	 <1205429946.8514.255.camel@twins>
Content-Type: text/plain
Date: Thu, 13 Mar 2008 10:56:14 -0700
Message-Id: <1205430974.10894.86.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1109
Lines: 28


On Thu, 2008-03-13 at 18:39 +0100, Peter Zijlstra wrote:

> > These need to be removed, but the usage is clearly not compatible with
> > the mutex API ..
> > 
> > If you convert them to atomic counts then you loose the sleeping aspect
> > of the semaphore, which you'd have to add back somehow.
> > 
> > The only API that seems straight forward is using complete's .. Then you
> > get an atomic count and all the sleeping function calls you might want..
> > (include/linux/completion.h) The problem with complete's is that you
> > can't start them out at "1" or "completed" unless you actually run
> > complete() once during initialization (that's kind of ugly) ..
> 
> A simple waitqueue would work.

I was just mulling over what the most straight forward way would be.. I
thought about wait queues, but the API didn't seem as easy to use a
completes..

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/