Date: Thu, 13 Mar 2008 21:54:27 +0100
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: David Brownell <david-b@pacbell.net>
Cc: kernel@avr32linux.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] atmel_serial: Fix build on avr32 with CONFIG_PM
 enabled
Message-ID: <20080313215427.0d1a86fc@siona.local>
In-Reply-To: <200803131337.41337.david-b@pacbell.net>
References: <1205419185-26395-2-git-send-email-hskinnemoen@atmel.com>
	<1205419185-26395-3-git-send-email-hskinnemoen@atmel.com>
	<200803131337.41337.david-b@pacbell.net>
Organization: Atmel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1099
Lines: 26

On Thu, 13 Mar 2008 12:37:40 -0800
David Brownell <david-b@pacbell.net> wrote:

> On Thursday 13 March 2008, Haavard Skinnemoen wrote:
> > AVR32 doesn't have at91_suspend_entering_slow_clock(). Just assume the
> > clock will keep running for now.  
> 
> Well, it should acquire the clk_must_disable() or somesuch... :)

Indeed. But that interface doesn't exist yet...

> By the way, I noticed a goof in this driver's clock management.
> It should leave the clock off whenever the device isn't open.
> As it is, it wastes power both at runtime and during suspend.

Right. I suspect you'll find a similar goofs in lots of drivers if you
go looking. I intend to go through all the drivers I care about and see
if I can tighten up the clock management a bit. There are probably a
few missing or half-assed suspend/resume implementations around too.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/