Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756838AbYCMVyP (ORCPT ); Thu, 13 Mar 2008 17:54:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752849AbYCMVyA (ORCPT ); Thu, 13 Mar 2008 17:54:00 -0400 Received: from an-out-0708.google.com ([209.85.132.241]:24209 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752405AbYCMVx7 convert rfc822-to-8bit (ORCPT ); Thu, 13 Mar 2008 17:53:59 -0400 Message-ID: Date: Thu, 13 Mar 2008 15:53:58 -0600 From: "Grant Likely" To: "=?ISO-8859-1?Q?Hans-J=FCrgen_Koch?=" , "Josh Boyer" , linuxppc-embedded@ozlabs.org Subject: Re: Linux UIO driver cache problem in PowerPC (fix) Cc: "Jean-Samuel Chenard" , "Thomas Gleixner" , LKML , "Greg KH" In-Reply-To: <20080313081932.4edee290@dilbert.local> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Content-Disposition: inline References: <169c03cb0803121222h5fca9cdal5af873cd2a700f4d@mail.gmail.com> <20080313081932.4edee290@dilbert.local> X-Google-Sender-Auth: c0ecdd210e684920 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3050 Lines: 97 On Thu, Mar 13, 2008 at 1:19 AM, Hans-J?rgen Koch wrote: > Am Wed, 12 Mar 2008 15:22:59 -0400 > schrieb "Jean-Samuel Chenard" : > > > Hi, > > Hi Jean-Samuel, > thanks for your report. Please CC LKML if you find bugs like this. I > also added Grant Likely (PPC Xilinx Virtex maintainer), as it seems to > be a platform specific problem. Hmmm. I'm not a memory handling expert so I don't know what's going on here. Josh, does this look like anything that would be ppc405 related? g. > > > > > Experimenting with your userspace I/O driver on a Xilinx FPGA (PowerPC > > 405), I was having problems when reading hardware device registers > > mapped on my platform using the user-space mmap() call. > > > > After some investigation (looking at the driver/char/mspec.c file), I > > found that preventing caching of the page in uio_mmap_physical fixed > > my issues with userspace mmap() reading messed-up values. > > Hm, we already mark the page with VM_IO. That's sufficient on x86 and > arm. I'm not sure whether this is a bug in PPC memory handling. Why do > they cache VM_IO pages? > > > > > This patch is against your initial commit of the UIO driver in the > > mainline kernel tree. > > > > ==== > > diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c > > index 865f32b..36e1123 100644 > > --- a/drivers/uio/uio.c > > +++ b/drivers/uio/uio.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > > > #define UIO_MAX_DEVICES 255 > > > > @@ -447,6 +448,8 @@ static int uio_mmap_physical(struct > > vm_area_struct *vma) > > > > vma->vm_flags |= VM_IO | VM_RESERVED; > > > > + vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > > + > > return remap_pfn_range(vma, > > vma->vm_start, > > idev->info->mem[mi].addr >> PAGE_SHIFT, > > ==== > > > > I am a bit unsure if this will break something in any of your uses of > > the UIO driver (on other platforms than ppc), but it really fixes > > things for me. > > It should be OK, but unneccesary on other platforms. I have no > objections, but I fear in 6 months we'll see a patch removing that > line again because it's not needed... > > > Let me know if you need more details on what was > > happening on my platform before I added this statement. > > I'd like to hear the opinion of people really involved in PPC memory > handling. > > > > > Thanks for the great driver for user-space I/O, it will save me lots > > of time in my research. > > > > Regards, > > > > Jean-Samuel > > Thanks, > Hans > > -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/