Date: Fri, 14 Mar 2008 10:34:31 +0900
From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>, "Ingo Molnar" <mingo@elte.hu>,
       "Andi Kleen" <ak@suse.de>, "Christoph Lameter" <clameter@sgi.com>,
       linux-kernel@vger.kernel.org, "Yasunori Goto" <y-goto@jp.fujitsu.com>
Subject: Re: [PATCH] mm: make reserve_bootmem can crossed the nodes
Message-Id: <20080314103431.ff07070c.kamezawa.hiroyu@jp.fujitsu.com>
In-Reply-To: <86802c440803131645q1eb31cb7jb0774d9cf67c767@mail.gmail.com>
References: <86802c440803131645q1eb31cb7jb0774d9cf67c767@mail.gmail.com>
Organization: Fujitsu
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 854
Lines: 28

On Thu, 13 Mar 2008 16:45:42 -0700
"Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
> int __init reserve_bootmem(unsigned long addr, unsigned long size,
>  			    int flags)
>  {
> -	return reserve_bootmem_core(NODE_DATA(0)->bdata, addr, size, flags);
> +	int ret;
> +	bootmem_data_t *bdata;
> +	list_for_each_entry(bdata, &bdata_list, list) {
> +		ret = can_reserve_bootmem_core(bdata, addr, size, flags);
> +		if (ret < 0)
> +			return ret;
> +	}
> +	list_for_each_entry(bdata, &bdata_list, list)
> +		reserve_bootmem_core(bdata, addr, size, flags);
> +	return 0;
>  }

why list_for_each twice ?

Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/