DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=fzy39ukycxoz3Ov0YT9aHNgqnYdEDCqMk+eY5URR05TsgIkh1IKuRuoREMMJ1DIc/BXvqj5QFz1PVPJt5wibch8Xl22/oSmrA0x+6WPoXbrP+CF61mcWgs3etWnXvOu2wfvxiLEFAd5TLn6+Sqw6N6AVi2kuZSwFZ981tn1b05A=
Message-ID: <86802c440803131835u4e506d69l4f116eb49d9ee9b2@mail.gmail.com>
Date: Thu, 13 Mar 2008 18:35:51 -0700
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH] mm: make reserve_bootmem can crossed the nodes
Cc: "Andrew Morton" <akpm@linux-foundation.org>, "Ingo Molnar" <mingo@elte.hu>,
       "Andi Kleen" <ak@suse.de>, "Christoph Lameter" <clameter@sgi.com>,
       linux-kernel@vger.kernel.org, "Yasunori Goto" <y-goto@jp.fujitsu.com>
In-Reply-To: <20080314103431.ff07070c.kamezawa.hiroyu@jp.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <86802c440803131645q1eb31cb7jb0774d9cf67c767@mail.gmail.com>
	 <20080314103431.ff07070c.kamezawa.hiroyu@jp.fujitsu.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1183
Lines: 33

On Thu, Mar 13, 2008 at 6:34 PM, KAMEZAWA Hiroyuki
<kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Thu, 13 Mar 2008 16:45:42 -0700
>  "Yinghai Lu" <yhlu.kernel@gmail.com> wrote:
>  > int __init reserve_bootmem(unsigned long addr, unsigned long size,
>  >                           int flags)
>  >  {
>  > -     return reserve_bootmem_core(NODE_DATA(0)->bdata, addr, size, flags);
>  > +     int ret;
>  > +     bootmem_data_t *bdata;
>  > +     list_for_each_entry(bdata, &bdata_list, list) {
>  > +             ret = can_reserve_bootmem_core(bdata, addr, size, flags);
>  > +             if (ret < 0)
>  > +                     return ret;
>  > +     }
>  > +     list_for_each_entry(bdata, &bdata_list, list)
>  > +             reserve_bootmem_core(bdata, addr, size, flags);
>  > +     return 0;
>  >  }
>
>  why list_for_each twice ?

first_for_each only check if we can reserve that.
second will do the reserve job.

Thanks

Yinghai Lu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/