Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758073AbYCNOQb (ORCPT ); Fri, 14 Mar 2008 10:16:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757185AbYCNOQU (ORCPT ); Fri, 14 Mar 2008 10:16:20 -0400 Received: from khc.piap.pl ([195.187.100.11]:46206 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753446AbYCNOQT (ORCPT ); Fri, 14 Mar 2008 10:16:19 -0400 To: Jan Engelhardt Cc: Jeff Garzik , Andrew Morton , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] Re: WAN: new PPP code for generic HDLC References: From: Krzysztof Halasa Date: Fri, 14 Mar 2008 15:16:16 +0100 In-Reply-To: (Krzysztof Halasa's message of "Wed\, 12 Mar 2008 21\:10\:31 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 581 Lines: 17 Krzysztof Halasa writes: > It can't if the hdlc header is 32-bit aligned... however, I can now > see the above is buggy, skb->data doesn't point to the protocol > field. Unused code paths :-( Actually I was wrong, the code is correct and skb->data points to the proto ID. PATCH v2 is on the way. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/