Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757371AbYCOAQf (ORCPT ); Fri, 14 Mar 2008 20:16:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751546AbYCOAQ0 (ORCPT ); Fri, 14 Mar 2008 20:16:26 -0400 Received: from netops-testserver-3-out.sgi.com ([192.48.171.28]:49220 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751291AbYCOAQZ (ORCPT ); Fri, 14 Mar 2008 20:16:25 -0400 Date: Fri, 14 Mar 2008 17:15:27 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: "Zhang, Yanmin" cc: Andrew Morton , Kay Sievers , Greg Kroah-Hartman , LKML , Ingo Molnar Subject: Re: hackbench regression since 2.6.25-rc In-Reply-To: Message-ID: References: <1205394417.3215.85.camel@ymzhang> <20080313014808.f8d25c2a.akpm@linux-foundation.org> <1205400538.3215.148.camel@ymzhang> <1205463842.3215.188.camel@ymzhang> <1205478861.3215.279.camel@ymzhang> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 28 Here is a patch to just not perform refills but switch slabs instead. Could check what effect doing so has on the statistics you see on the 16p? --- mm/slub.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) Index: linux-2.6/mm/slub.c =================================================================== --- linux-2.6.orig/mm/slub.c 2008-03-14 16:49:36.000000000 -0700 +++ linux-2.6/mm/slub.c 2008-03-14 16:50:04.000000000 -0700 @@ -1474,10 +1474,7 @@ static void *__slab_alloc(struct kmem_ca goto new_slab; slab_lock(c->page); - if (unlikely(!node_match(c, node))) - goto another_slab; - - stat(c, ALLOC_REFILL); + goto another_slab; load_freelist: object = c->page->freelist; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/