Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752441AbYCOGet (ORCPT ); Sat, 15 Mar 2008 02:34:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751587AbYCOGek (ORCPT ); Sat, 15 Mar 2008 02:34:40 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:48933 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbYCOGej (ORCPT ); Sat, 15 Mar 2008 02:34:39 -0400 Date: Sat, 15 Mar 2008 02:34:03 -0400 From: Christoph Hellwig To: Mike Snitzer Cc: Christoph Hellwig , Jeff Layton , akpm@linux-foundation.org, neilb@suse.de, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] NLM: Initialize completion variable in lockd_up Message-ID: <20080315063403.GA6942@infradead.org> References: <1199820798-5289-1-git-send-email-jlayton@redhat.com> <1199820798-5289-2-git-send-email-jlayton@redhat.com> <1199820798-5289-3-git-send-email-jlayton@redhat.com> <1199820798-5289-4-git-send-email-jlayton@redhat.com> <20080109173542.GA30523@infradead.org> <20080113082718.396890f7@tleilax.poochiereds.net> <20080113181743.GA20219@infradead.org> <170fa0d20803142044i3e4d134fq5b287134248a113f@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <170fa0d20803142044i3e4d134fq5b287134248a113f@mail.gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 18 On Fri, Mar 14, 2008 at 10:44:31PM -0500, Mike Snitzer wrote: > On Sun, Jan 13, 2008 at 1:17 PM, Christoph Hellwig wrote: > > Btw, lockd() takes BKL just after starting up and only implicitly drops > > it when blocking. This seems very dangerous to me and badly wants > > updating to some real locking scheme.. > > Can you elaborate on what is meant by lockd "blocking"? Blocking in > svc_recv() or during a SETLKW or ??? Blocking in kernel context means sleeping aka scheduling away. So in the sentence above that means BKL is dropped once lockd sleeps on a syncronization primitive the first time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/