Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754597AbYCORYj (ORCPT ); Sat, 15 Mar 2008 13:24:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754280AbYCORYa (ORCPT ); Sat, 15 Mar 2008 13:24:30 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:33687 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754244AbYCORY3 (ORCPT ); Sat, 15 Mar 2008 13:24:29 -0400 Date: Sat, 15 Mar 2008 18:24:18 +0100 (CET) From: Roman Zippel X-X-Sender: roman@scrub.home To: Ingo Oeser cc: john stultz , lkml , Ingo Molnar Subject: Re: [PATCH 4/5] ntp.c code flow clenaups (from Ingo) In-Reply-To: <200803151339.21101.ingo.oeser@rameria.de> Message-ID: References: <1205553852.6122.76.camel@localhost.localdomain> <1205554210.6122.85.camel@localhost.localdomain> <1205554366.6122.88.camel@localhost.localdomain> <200803151339.21101.ingo.oeser@rameria.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 592 Lines: 18 Hi, On Sat, 15 Mar 2008, Ingo Oeser wrote: > I don't understand, why the goto is required here. > > If you move these two cases in front of case "TIME_OK" and > omit the break, you can remove the goto and the label "start_timer". > Don't forget the /* fall through */ comment then. Nice catch, I'll do this in the original patch. bye, Roman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/