Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754040AbYCOTr7 (ORCPT ); Sat, 15 Mar 2008 15:47:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752575AbYCOTrv (ORCPT ); Sat, 15 Mar 2008 15:47:51 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:1867 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752445AbYCOTru (ORCPT ); Sat, 15 Mar 2008 15:47:50 -0400 Date: Sat, 15 Mar 2008 14:16:11 +0100 From: Pavel Machek To: Venki Pallipadi Cc: Len Brown , "Rafael J. Wysocki" , Miklos Szeredi , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: ACPI lockdep warning on boot, 2.6.25-rc5 Message-ID: <20080315131611.GA4828@ucw.cz> References: <200803122301.17356.rjw@sisk.pl> <200803131614.33386.lenb@kernel.org> <20080314001819.GA32584@linux-os.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080314001819.GA32584@linux-os.sc.intel.com> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 856 Lines: 36 Hi! > @@ -421,7 +423,9 @@ > else > acpi_safe_halt(); > > - local_irq_enable(); > + if (irqs_disabled()) > + local_irq_enable(); > + > return; > } > > @@ -530,7 +534,9 @@ > * skew otherwise. > */ > sleep_ticks = 0xFFFFFFFF; > - local_irq_enable(); > + if (irqs_disabled()) > + local_irq_enable(); > + > break; > > case ACPI_STATE_C2: That's pretty ugly. Could the code be modified to have interrupt consistent at this point? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/