Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755322AbYCOVxf (ORCPT ); Sat, 15 Mar 2008 17:53:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754924AbYCOVxW (ORCPT ); Sat, 15 Mar 2008 17:53:22 -0400 Received: from netrider.rowland.org ([192.131.102.5]:2880 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754852AbYCOVxU (ORCPT ); Sat, 15 Mar 2008 17:53:20 -0400 Date: Sat, 15 Mar 2008 17:53:20 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Greg KH , Andrew Morton , "Rafael J. Wysocki" cc: Kamalesh Babulal , , , Kernel development list , , Len Brown , Linux-pm mailing list Subject: [PATCH 1/3] Fix misuse of wakeup flag accessors in serial core In-Reply-To: <200803142337.12605.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1054 Lines: 27 This patch (as1059) fixes a mistake in the way the serial core initializes a device's wakeup settings. It should use the accessor routine instead of relying on a macro producing an lvalue. Signed-off-by: Alan Stern --- Index: usb-2.6/drivers/serial/serial_core.c =================================================================== --- usb-2.6.orig/drivers/serial/serial_core.c +++ usb-2.6/drivers/serial/serial_core.c @@ -2356,7 +2356,7 @@ int uart_add_one_port(struct uart_driver */ tty_dev = tty_register_device(drv->tty_driver, port->line, port->dev); if (likely(!IS_ERR(tty_dev))) { - device_can_wakeup(tty_dev) = 1; + device_init_wakeup(tty_dev, 1); device_set_wakeup_enable(tty_dev, 0); } else printk(KERN_ERR "Cannot register tty device on line %d\n", -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/