Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752580AbYCPTBL (ORCPT ); Sun, 16 Mar 2008 15:01:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752169AbYCPTA6 (ORCPT ); Sun, 16 Mar 2008 15:00:58 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:54156 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752167AbYCPTA5 (ORCPT ); Sun, 16 Mar 2008 15:00:57 -0400 Date: Sun, 16 Mar 2008 18:44:59 +0000 From: Alan Cox To: Linus Torvalds Cc: Anders Eriksson , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Jens Axboe , Ingo Molnar , Linux Kernel Mailing List Subject: Re: Linux 2.6.25-rc4 Message-ID: <20080316184459.098e18b6@core> In-Reply-To: References: <200803101336.56159.bzolnier@gmail.com> <200803101410.27877.rjw@sisk.pl> <200803101504.17219.bzolnier@gmail.com> <20080316140118.891732DC044@tippex.mynet.homeunix.org> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 777 Lines: 19 O> @@ -462,8 +462,7 @@ static ide_startstop_t ide_ata_error(ide_drive_t *drive, struct request *rq, u8 > } > } > > - if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ && > - (hwif->host_flags & IDE_HFLAG_ERROR_STOPS_FIFO) == 0) > + if ((stat & DRQ_STAT) && rq_data_dir(rq) == READ) > try_to_flush_leftover_data(drive); That is instant system death on some chipsets. The state machine on the promise for example empties the FIFO and if you touch the data port again before issuing a command you lock the PCI bus. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/