From: Neil Brown <neilb@suse.de>
To: "J. Bruce Fields" <bfields@fieldses.org>
Date: Mon, 17 Mar 2008 10:19:20 +1100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <18397.43768.705353.514972@notabene.brown>
Cc: Lukas Hejtmanek <xhejtman@ics.muni.cz>, nfsv4@linux-nfs.org,
       linux-kernel@vger.kernel.org
Subject: Re: Oops in NFSv4 server in 2.6.23.17
In-Reply-To: message from J. Bruce Fields on Friday March 14
References: <20080312122550.GB8141@ics.muni.cz>
	<20080312160007.GA10015@fieldses.org>
	<20080313143631.GH27873@ics.muni.cz>
	<20080314181413.GF2119@fieldses.org>
	<20080314193350.GK2119@fieldses.org>
	<20080314195303.GA4390@ics.muni.cz>
	<20080314200510.GL2119@fieldses.org>
	<20080314234205.GO2119@fieldses.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 959
Lines: 23

On Friday March 14, bfields@fieldses.org wrote:
> On Fri, Mar 14, 2008 at 04:05:10PM -0400, bfields wrote:
> > I find that a little contorted.  So I'll go ahead and submit this small
> > patch to 2.6.25 and stable now (I have since managed to reproduce what I
> > believe is your bug, though my symptoms were a little different), and
> > then submit to 2.6.26 some cleanup which makes this more understandable,
> 
> Here's an attempt.  We could break up fh_verify even more, though.--b.

Looks like a good attempt.

My only suggestion would be to put a comment at the top of
nfsd_set_fh_dentry explaining what it does and who calls it.

It's long past time that code had some spring cleaning !!

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/